Ticket #93 (closed defect: fixed)

Opened 10 months ago

Last modified 9 months ago

Rules with $url.scheme=='chrome' are ignored

Reported by: esquifit@googlemail.com Assigned to: t-bone
Priority: major Component: Karma Blocker
Version: 0.2.1 Severity: Broken
Keywords: chrome Cc:

Description (Last modified by t-bone)

Rules with $url.scheme=='chrome' are not taken into account. As a consequence the security feature of blocking chrome access to web pages does not work at all.

The reason is a bug in the source code of kabl-policy.js, namely a reference to a non-existing object 'originLocation' is being used instead of 'requestOrigin'. Diff follows: 

--- kabl-policy.js_orig	2007-06-28 10:58:20.000000000 +0200
+++ kabl-policy.js	2007-11-10 01:51:42.229006400 +0100
@@ -204,7 +204,7 @@
 
 		// if it is chrome, and so is the origin, let it through
 		if (contentLocation.schemeIs('chrome') &&
-			originLocation.schemeIs('chrome')
+			requestOrigin.schemeIs('chrome')
 		) {
 			return this.ACCEPT;
 		}

Attachments

Change History

12/04/07 15:23:31 changed by t-bone

  • status changed from new to assigned.
  • description changed.
  • severity changed from Feature to Broken.

12/11/07 22:05:47 changed by t-bone

  • status changed from assigned to closed.
  • resolution set to fixed.

Thanks very much for this report! Quite embarrassing that it got left in there. I find that writing code as components is always extra tough; error reporting doesn't seem to be very good.

Add/Change #93 (Rules with $url.scheme=='chrome' are ignored)




Action