TinyMenu causes the gContactSync Address Book Toolbar Menu to disappear

[tanstaafl@…]

Windows XP Pro sp2 up to date Thunderbird 2.0.0.23 TinyMenu 2.0.1 gContactSync 0.2.8

To reproduce:

1. install gContactSync 0.2.8, restart Thunderbird (cancel the account setup prompt), open the Address Book (cancel the account setup prompt), see the toolbar menu for gContactSync.

2. install TinyMenu 2.0.1, restart Thunderbird, open the Address Book (cancel the account setup prompt), notice the gContactSync menu is not available in the TinyMenu menu.

If the fix needs to be made in gContactSync, I'll be happy to report it there.

Thx!

[joshgeenen@…]

This should be fixed in gContactSync, so I have added a workaround to gContactSync. Version 0.2.9 should be released within a week with the fix.

See Bug 21840 (sorry there is no link, but this post matched the spam filter when I included a link)

Josh

[t-bone]

Replying to joshgeenen@…:

This should be fixed in gContactSync..

That's a bit interesting. I haven't investigated attempts to add menus via DOM operations, before. Is there any reason that this XUL isn't simply specified in an overlay? If you're looking for conditional display, the best way I've seen it done is to specify the markup in a XUL overlay, and use the  hidden attribute to hide it from the user, when you don't want them to see it. When you do, take off the hidden attribute.

[t-bone]

Whoops, adding joshgeenen@ to cc. Josh: please reply to my question above if you can.

[joshgeenen@…]

I believe I did it originally because Seamonkey and Thunderbird have different menubar ID's and I didn't want to duplicate the XUL for the menus. In the end, duplicating the code probably still would've been shorter than all that JavaScript.