Ticket #355 (closed task: fixed)

Opened 12 months ago

Last modified 10 months ago

Triplicate Options Columns

Reported by: siegfre@… Owned by: t-bone
Priority: minor Component: Tiny Menu
Version: 2.0.1 Severity: Nuisance
Keywords: Cc: thgreasi@…

Description

Running TM 2.0.1 & TB 2.0.0.23 When selecting TM OPTIONS the Do NOT collapse these menu panel has 3 columns of options instead of 1. See attached bmp.

Attachments

TM.png Download (13.6 KB) - added by siegfre@… 12 months ago.
TM OPTIONS panel in TB
tinymenu-2.0.2-pre.xpi Download (18.5 KB) - added by t-bone 11 months ago.
Testing preview of this fix
TM2.png Download (8.3 KB) - added by Siegfre@… 11 months ago.
TM2.02 Options Menu
TM3.png Download (7.9 KB) - added by siegfre@… 11 months ago.
TM2.02 with Cleared tinymenu.allMenus
tinymenu-2.0.2-pre2.png Download (40.4 KB) - added by t-bone 10 months ago.
screenshot of tiny menu configuration for this version
tinymenu-2.0.2-pre2.xpi Download (18.7 KB) - added by t-bone 10 months ago.
testing installer, round 2

Change History

Changed 12 months ago by siegfre@…

TM OPTIONS panel in TB

  Changed 12 months ago by newcomer01

this reported problem isn't exist in Firefox 3.5.3 and with the latest Tiny Menu Version 2.0.1 german locale - the options menu has one column

  Changed 12 months ago by siegfre@…

TM works OK in Firefox. The problem only appears in Thunderbird.

follow-up: ↓ 5   Changed 12 months ago by t-bone

Would you mind accessing: Tools > Options > Advanced > General > Config Editor, finding the preference named "tinymenu.allMenus" and pasting it here? Please put it in a

preformatted block

Which you create with:

 {{{
 triple curly braces on their own line (with no space)
 }}}

  Changed 12 months ago by t-bone

Sorry, pasting its contents here. Get it with a right click and "Copy value".

in reply to: ↑ 3   Changed 12 months ago by siegfre@…

Replying to t-bone:

Would you mind accessing: Tools > Options > Advanced > General > Config Editor, finding the preference named "tinymenu.allMenus" and pasting it here? Please put it in a {{{ ({' chrome://messenger/content/messenger.xul Mozilla Thunderbird':{tinymenu:{collapse:false, image:"chrome://tinymenu/skin/tinymenu.png"}, 'menu_File File':{collapse:true}, 'menu_Edit Edit':{collapse:true}, 'menu_View View':{collapse:true}, 'menu_Go Go':{collapse:true}, 'messageMenu Message':{collapse:true}, 'tasksMenu Tools':{collapse:true}, 'menu_HelpWin Help':{collapse:true}}, ' chrome://messenger/content/messageWindow.xul Mozilla Thunderbird':{tinymenu:{collapse:false, image:"chrome://tinymenu/skin/tinymenu.png"}, 'menu_File File':{collapse:true}, 'menu_Edit Edit':{collapse:true}, 'menu_View View':{collapse:true}, 'menu_Go Go':{collapse:true}, 'messageMenu Message':{collapse:true}, 'tasksMenu Tools':{collapse:true}, 'menu_HelpWin Help':{collapse:true}}, ' chrome://messenger/content/messenger.xul ':{tinymenu:{collapse:false, image:"chrome://tinymenu/skin/tinymenu.png"}, 'menu_File File':{collapse:true}, 'menu_Edit Edit':{collapse:true}, 'menu_View View':{collapse:true}, 'menu_Go Go':{collapse:true}, 'messageMenu Message':{collapse:true}, 'tasksMenu Tools':{collapse:true}, 'menu_HelpWin Help':{collapse:true}}, ' chrome://messenger/content/messageWindow.xul ':{tinymenu:{collapse:false}, 'menu_File File':{collapse:true}, 'menu_Edit Edit':{collapse:true}, 'menu_View View':{collapse:true}, 'menu_Go Go':{collapse:true}, 'messageMenu Message':{collapse:true}, 'tasksMenu Tools':{collapse:true}, 'menu_HelpWin Help':{collapse:true}}}) }}} Which you create with: {{{ {{{ triple curly braces on their own line (with no space) }}} }}}

  Changed 12 months ago by siegfre@…

I noticed that "tinymenu.allMenus" had values repeated several times. I'm not sure why. But I uninstalled TM, deleted the values from about:config then reinstalled TM. Everything is OK now.

  Changed 12 months ago by siegfre@…

I just noticed that the multiple columns are back again in TM OPTIONS. Let me know if there's any additional info/debug you need.

  Changed 12 months ago by t-bone

  • status changed from new to accepted

There's two issues going on here.

  1. The title of the window is stored, to display at the top of the options dialog. That isn't working properly, so the same dialog is stored once with the "Mozilla Thunderbird" title, and once with an empty title. This I can fix.
  2. My design is flawed. Thunderbird has two "main" windows:  https://developer.mozilla.org/en/Thunderbird/Main_Windows One you see when you launch the program, the second when you open a message. They have the same menu options, and the same title. I'm not sure now how to clearly communicate which is which (especially across all the languages TM is available in).

  Changed 12 months ago by t-bone

(In [579]) Refs #355, #358

  • First pass of changes to de-dupe windows purely on URL, with title as a secondary attribute.

Changed 11 months ago by t-bone

Testing preview of this fix

  Changed 11 months ago by t-bone

Please try installing this preview version with a likely fix. Let me know if it helps.

Changed 11 months ago by Siegfre@…

TM2.02 Options Menu

  Changed 11 months ago by siegfre@…

It looks like the fix broke TM. I've attached a copy of the OPTIONS Menu. Can't get TM to collapse menus

  Changed 11 months ago by t-bone

  • cc thgreasi@… added

Crud. And what happens now if you clear the "tinymenu.allMenus" preference?

Tools, options, advanced, general, config editor. Filter for "tiny", find that one, right click, choose reset, relaunch Thunderbird.

  Changed 11 months ago by siegfre@…

see attachement. Cleared tinymenu.allMenus. Collapse these menus shows no options

Changed 11 months ago by siegfre@…

TM2.02 with Cleared tinymenu.allMenus

  Changed 10 months ago by t-bone

After repeated testing, I still cannot reproduce this issue. I won't be able to continue with this without your help.

First: * Uninstall Tiny Menu (including restart) * Open the config editor (Tools>Options>Advanced>Config Editor) * Filter: tinymenu * For each item in the list, right click and choose "Reset" * Restart * Reinstall

Does that help at all? If not, please read Tickets and provide all the information requested there.

I'd like to help but without this, I'll have to wontfix this ticket.

  Changed 10 months ago by siegfre@…

I tried your suggestions. After re-installing the TM extension everything is OK UNTIL I open an email. After opening an email the TM options shows a new column. Here's the info you requested: * problem only occurs in Thunderbird?

  • What version? I'm currently using 2.0.0.24
  • The english language version? English

* What operating system? WinXP Home Edition SP3 * Do you have other extensions installed? Yes

  • Which?

Allow Empty Subject AttachmentReminder ConfirmFolderMove No New Window On Double Click ProfilePassword Xpunge

* Do you have other themes installed? No, I'm using the default TB theme * Have you tried testing with a BlankProfile? I have not. I will try uninstalling/reinstalling my other extension to find out if any one of them are the culprit.

Changed 10 months ago by t-bone

screenshot of tiny menu configuration for this version

Changed 10 months ago by t-bone

testing installer, round 2

  Changed 10 months ago by t-bone

After opening an email the TM options shows a new column

It's supposed to show one new column. One for the main window, and one for the compose window: they have different menu bars.

I actually just tested this to show how it's "supposed" to look, and saw it bugged, showing columns with no headings, with 2.0.1. If I add the 2.0.2-pre posted above, I see three undefined column headings with no data just like you did. Looking at it, I think I realize what the problem is.

So try tinymenu-2.0.2-pre2.xpi, attached, which looks like the attached screenshot with that name (for me).

  Changed 10 months ago by siegfre@…

I just tried TM 2.0.2-pre2. Now I see Column headings for "Mozilla Thunderbird" & one for "Compose". Now I understand why there are separate columns. It looks like you fixed it :-)

Let me know if you need any additional testing/doc.

  Changed 10 months ago by siegfre@…

I spoke too soon. It looks like TM 2.0.2-pre2 does not keep the option for IMAGE [Default}. When I restart TB the option goes back to TEXT.

  Changed 10 months ago by t-bone

  • status changed from accepted to closed
  • resolution set to fixed

I'm marking this as fixed. If the final 2.0.2 version release (submitting for review today, will be on AMO once it is reviewed) still has the image problem, please submit a new ticket, but it's working for me.

Add/Change #355 (Triplicate Options Columns)

Author


E-mail address and user name can be saved in the Preferences.


Action
as closed
The resolution will be deleted. Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.