file:// URLs break Uppity

[sarahwbs@…]

Since the latest update was installed a few days ago, Uppity no longer works for me. The toolbar button is greyed-out. If I remove the button and re-add it, it appears to be active, but clicking the button only shows a teeny tiny menu popping up, that obviously has nothing in it.

[sarahwbs@…]

FYI, FF is version 3.0.10, Uppity is version 1.5.2.

[t-bone]

Do you see any messages in the Firefox Error Console?

[sarahwbs@…]

I tried moving to the latest experimental version, but that did not help. So I've gone back to 1.5.2. Now the button is not greyed out, but it seems to only allow me to move up one level using the button. If I use the menu to specify which level to move to it works fine, it's just doing the single click that appears to only work once. After that I'm stuck, the button refreshes the current URL rather than moving up.

[t-bone]

(I know it's hard, the spam filter sucks but is necessary. Try inserting some spaces to 'break the link'.) Can you tell me what URL this happens at?

[sarahwbs@…]

Sorry, no, there are no errors in the console (at least none related to Uppity).

[sarahwbs@…]

Seems to be doing it on every URL, but some examples are:

addons.mozilla.org /en-US/firefox/addon/869 trac.arantius.com /ticket/274

[t-bone]

Sigh, you're quite right. I clearly rushed this version too much.

[t-bone]

I can no longer reproduce this. I think like #273, it is just a problem in what code I included in version 1.5.3.

[sarahwbs@…]

Just wanted to let you know that I installed the latest experimental version (from May 20) and so far it seems to be working ok.

[murray@…]

I still have this problem with 1.5.4: the uppity item is just grayed out and on removing and re-adding doesn't do anything when pressed. I've reverting to 1.5.1 again.

This is on: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.10) Gecko/2009042315 Firefox/3.0.10

[pjj@…]

@murray & sarahwbs: I had the same issue with 1.5.4, BTW also with ver. 1.5.3. I re-installed Uppity (i.e. completely uninstalled and then installed again; re-enabling or re-adding to the toolbar hasn't done the trick) and voila, it works.

[murray@…]

@pjj thanks for the feedback. Unfortunately an uninstall and reinstall didn't fix it for me.

I've just tried installing uppity into a fresh profile and version 1.5.4 works fine there. So there's some bad interaction with some setting or extension in my main profile. It may take me some time to find out what's going on. I will report back if I ever work it out.

[t-bone]

Thanks for the detailed feedback everyone. I can confirm that I, rarely, see something like this. It will be a bear to figure out, I bet.

[sarahwbs@…]

Just updated to 1.5.4 on my work computer and not only does Uppity not work, my address bar doesn't work either! No address appears there when I open a bookmark, and when I type an address in the bar and hit enter or click on the go arrow, nothing happens.

[sarahwbs@…]

Replying to t-bone:

Thanks for the detailed feedback everyone. I can confirm that I, rarely, see something like this. It will be a bear to figure out, I bet.

Can you not just go back to 1.5.1, since that is the last one that was working correctly?

[murray@…]

I tried disabling (but not uninstalling) all my extensions. That didn't help. I can't see any suspicious non-default settings in about:config either. I'm not sure what it is about my profile that is interacting badly. Remember uppity works for me in a clean profile.

A diff between 1.5.1 and 1.5.2 suggests that there's something wrong with the new getUrls function. Maybe for some reason it always returns an empty list? I don't know how to go about debugging javascript in firefox though.

[t-bone]

You can debug javascript in Firefox with the  Javascript Debugger.

Opening that while I saw this happening shows:

Error ``m is null'' [x-] in file ``chrome://uppity/content/uppity.js'', line 109, character 0.

An exception that's caught somewhere but logged via Venkman. This is in parseUrl(). I'm still not sure what causes this, but it's a good lead to what's actually going wrong.

---

And, Sarah: You can surely install whatever version you like, but I don't want to throw away the hard work I put into the new features.

[sarahwbs@…]

Sorry, didn't mean to suggest you throw away your recent work, but rather that you can compare your current code to the code from 1.5.1 to narrow down the cause. Of course I have no idea how extensive the code is, so it may be easier said than done.

[t-bone]

Ah of course =) Yes, comparing to 1.5.1 makes a lot of sense. Right now, the differences are generally all still in my head.

[murray@…]

I've figured out what was causing me the problem. Thanks for the link to Venkman, I also needed to work out: developer.mozilla.org/en/Venkman_Introduction#Debugging_extensions

The problem was that my start page is set to a file on my local disk. A clean profile fixed the problem as it defaulted to a start page with a remote URL.

Start URLs like  file:///home/iam23/start.htm confuse a regex in recent versions of uppity that which doesn't allow the "host" part of the URL to be zero characters long. I have put a patch and a rebuilt xpi in: www.cs.toronto.edu/~murray/tmp/uppity/

Someone who knows the code better may wish to fix this issue more elegantly. For example  file://www./ isn't a sensible thing to have on uppity's list and there may be other problems with zero-length hostnames that I haven't encountered.

[t-bone]

Edited the summary to more accurately reflect what's been noted in this ticket. I've definitely reproduced this, and have a fix in the works.

I plan on finishing this fix, packaging an XPI with it, and attaching that here. I'll run it for a while to make sure it really fixes everything, and you're welcome to try that as well.

[t-bone]

(In [518]) Fixes #274

• Version bump
• Properly parse " file:///" URLs. (#274)
• Revamp error handling (and related indentation), errors are logged in the console and thus likely to be noticed if there are more in the future.

[t-bone]

Testing version with this ticket fixed

[murray@…]

Works for me. Thanks.