Ticket #209 (closed defect: fixed)

Opened 22 months ago

Last modified 15 months ago

Blocking of script disables viewing of entire page

Reported by: anonymous Owned by: t-bone
Priority: minor Component: Karma Blocker
Version: 0.3.2 Severity: Nuisance
Keywords: Cc: esquifit+kabl@…

Description

I think I am seeing a bug. When I try to view www.soledadclub.com I get a blank page. My configuration is attached (basically it is a simplified version of the developer's recommendations for debugging purposes).

I expect Karma Blocker to wipe out the google-analytics tracking script on the page (3rd party + script) and indeed if one looks at the generated source (with say the Web Developer extension) it is explicitly wiped out.

But curiously the entire page gets wiped out at the body element.

This does not seem correct.

Attachments

Configuration.txt Download (0.7 KB) - added by anonymous 22 months ago.
Karma Blocker configuration

Change History

Changed 22 months ago by anonymous

Karma Blocker configuration

Changed 21 months ago by t-bone

  • status changed from new to accepted

This is almost certainly related to the "Enhanced element collapsing" added in 0.3.1. You can try an earlier version to corroborate this.

I believe I'll add an option to control if/when/how this feature works more granularly in the next version.

Changed 17 months ago by ze@…

Did you ever end up adding this option? I can't see any use of it in the example rule set.

Changed 16 months ago by t-bone

See also related/duplicate tickets: #239, #264

Changed 16 months ago by t-bone

  • cc esquifit+kabl@… added

Cannot reproduce this at www.soledadclub.com .

Cannot reproduce the issue as at #239 .

But, I have definitely noticed behavior like this, in a variety of cases. It's very annoying, and needs fixing.

Changed 16 months ago by t-bone

Here's a page where <head> is blocked, clearly a bad thing:  http://www.babelgum.com/html/clip.php?clipId=147374

Changed 16 months ago by t-bone

<body> blocked:  http://doihaveswineflu.org/

Changed 15 months ago by t-bone

(In [520]) Refs #209

  • Do not ever collapse the BODY or HTML elements.
  • Add a new setting, "collapse", to globally enable or disable the element collapsing feature.

Changed 15 months ago by t-bone

  • status changed from accepted to closed
  • resolution set to fixed

I'm calling this done. The ability to disable the feature provides a workaround if there are more problems in the future, and I have no clear idea what should be done next/more in this direction.

Add/Change #209 (Blocking of script disables viewing of entire page)

Author


E-mail address and user name can be saved in the Preferences.


Action
as closed
The resolution will be deleted. Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.