Ticket #149 (closed defect: fixed)

Opened 3 months ago

Last modified 1 month ago

Flicker to right tab, then left, when closing

Reported by: t-bone Assigned to: t-bone
Priority: minor Component: Tab Control
Version: 0.4.1 Severity: Nuisance
Keywords: Cc:

Description

In Tab Control 0.4.1, with "focus left tab when closing current tab" turned on, and a tab to the right of the current tab, when the current tab is closed, the tab to the right displays briefly, before the left tab is focused.

Attachments

tabcontrol-0.4.2.xpi (15.8 kB) - added by t-bone on 07/24/08 20:12:38.
Here's a preview release with exactly this change.

Change History

07/23/08 11:42:33 changed by Skiff

I've already sent an information about solution of this to TabControl autor, but I think I can post it here too

In TabControl code (file tabcontrol.js) find these lines:

//set focus to the tab that we want gTabControl.selectTab(tabToSelect);

and put them before these lines:

//call the browser's real remove tab function gBrowser.origRemoveTab(aTab);

and save changes to tabcontrol.js and tab_control-0.4.1.xpi file. Tested on FF3.01 and tab_control_0.4.1

07/23/08 11:45:04 changed by Skiff

Once again because formating in above post went wrong, the lines are:

//set focus to the tab that we want

gTabControl.selectTab(tabToSelect);

and

//call the browser's real remove tab function

gBrowser.origRemoveTab(aTab);

07/24/08 20:11:52 changed by t-bone

  • status changed from new to assigned.

Thanks for the suggestion! I never got around to looking into this myself, but this fix certainly works!

07/24/08 20:12:21 changed by t-bone

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [426]) Fixes #149

  • Fix tab flicker on close.
  • Bump version number.

07/24/08 20:12:38 changed by t-bone

  • attachment tabcontrol-0.4.2.xpi added.

Here's a preview release with exactly this change.

Add/Change #149 (Flicker to right tab, then left, when closing)




Action