Changeset 428

Timestamp:

08/07/08 21:47:29 (5 months ago)

Author:

t-bone

Message:

Refs #182

• Do not set extended-collapse marker attributes on <style> nodes.

Files:

• extension/kabl/content/kabl-policy.js (modified) (2 diffs)

extension/kabl/content/kabl-policy.js

@@ -206 +206 @@
             ('cutoff'==type && score>=gKablRulesObj.cutoff)
         ) {
-            // try block just in case, attempt to hide the node, i.e.
-            // if a non-loaded image will result in an alt tag showing
             try {
-                fields.node=fields.node
+                var el=fields.node
                     .QueryInterface(Components.interfaces.nsIDOMNode);
-                fields.node.setAttribute('style', 'display: none !important');
             } catch (e) {
                 if (gKablDebug) dump('Error in evalScore: '+e+'\n');
-            }
-
-            // mark a node for extended hiding
+                return;
+            }
+
+            // Attempt to hide the node, i.e. if a non-loaded image will
+            // result in an alt tag showing.
             try {
-                fields.node=fields.node
-                    .QueryInterface(Components.interfaces.nsIDOMNode);
-                fields.node.setAttribute('kabl', gKablCollapseMarker);
+                el.setAttribute('style', 'display: none !important');
+            } catch (e) {
+                if (gKablDebug) dump('Error in evalScore: '+e+'\n');
+            }
+
+            // Mark the node for collapsing.
+            try {
+                if ('STYLE'!=el.tagName) {
+                    el.setAttribute('kabl', gKablCollapseMarker);
+                }
             } catch (e) {
                 if (gKablDebug) dump('Error in evalScore: '+e+'\n');
@@ -284 +290 @@
                 if (el) {
                     el=el.QueryInterface(Components.interfaces.nsIDOMNode);
-                    //el.style.display='none !important';
                     el.setAttribute('style', 'display: none !important');
                     el.setAttribute('kablcollapse', '1');